Open
Conversation
zooko
reviewed
Jan 26, 2026
zooko
left a comment
zooko
left a comment
There was a problem hiding this comment.
I read over this patch and it looks correct to me.
zooko
reviewed
Jan 26, 2026
zooko
left a comment
zooko
left a comment
There was a problem hiding this comment.
I read over this patch and it looks correct to me. :-) (That was easy.)
jvoisin
reviewed
Feb 8, 2026
|
|
||
| if test "$setup_s" = "1"; then | ||
| checkout s $version_s https://github.com/zooko/smalloc | ||
| cargo build --release --package smalloc-ffi |
Collaborator
There was a problem hiding this comment.
You might want to add cargo as a dependency in the install packages phase.
Collaborator
Author
There was a problem hiding this comment.
Yeah, I realised that, but I was nudging github from my phone. I'll fix today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #248. This is based on @zooko's personal fork.