Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPSH 1663 fix import spec #124

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −3
Open

SPSH 1663 fix import spec #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9e9e56
remove unnecessary dialog click
jaggarnaut Jan 8, 2025
b5508fd
Merge branch 'main' of github.com:dBildungsplattform/schulportal-test…
jaggarnaut Jan 9, 2025
50d0417
fixed test
jaggarnaut Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pages/admin/PersonImportView.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { ComboBox } from '../../elements/ComboBox';
export class PersonImportViewPage {
readonly page: Page;
readonly body: Locator;
readonly personImportCard: Locator;
readonly headlineBenutzerImport: Locator;
readonly schuleSelectInput: Locator;
readonly schuleSelectCombobox: ComboBox;
Expand All @@ -25,6 +26,7 @@ export class PersonImportViewPage {
// Benutzerimport
this.page = page;
this.body = page.locator('body');
this.personImportCard = page.getByTestId('person-import-card');
this.headlineBenutzerImport = page.getByTestId('layout-card-headline');
this.schuleSelectInput = page.getByTestId('schule-select').locator('input');
this.schuleSelectCombobox = new ComboBox(this.page, this.schuleSelectInput,);
Expand All @@ -44,7 +46,6 @@ export class PersonImportViewPage {

public async navigateToPersonManagementView(): Promise<PersonManagementViewPage> {
await this.closeCardButton.click();
await this.confirmUnsavedChangesButton.click();

return new PersonManagementViewPage(this.page);
}
Expand Down
4 changes: 2 additions & 2 deletions tests/Import.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ test.describe(`Testfälle für den Benutzerimport": Umgebung: ${process.env.ENV}
.goToAdministration())
.goToBenutzerImport());

await expect(personImportPage.headlineBenutzerImport).toBeVisible();
await expect(personImportPage.personImportCard).toBeVisible();
});
});

Expand All @@ -57,7 +57,7 @@ test.describe(`Testfälle für den Benutzerimport": Umgebung: ${process.env.ENV}
});
});

test.skip('Als Landesadmin eine CSV-Datei mit Benutzerdaten hochladen und importieren', {tag: [LONG]}, async ({ page }) => {
test('Als Landesadmin eine CSV-Datei mit Benutzerdaten hochladen und importieren', {tag: [LONG]}, async ({ page }) => {
// Der Test ist aktuell rot, wird mit SPSH-1663 gefixed
await test.step('CSV-Datei hochladen, importieren und importierte Daten downloaden', async () => {
// select schule
Expand Down
Loading