Skip to content

Commit

Permalink
SPSH 1663 fix import spec (#124)
Browse files Browse the repository at this point in the history
* remove unnecessary dialog click

* fixed test
  • Loading branch information
jaggarnaut authored Jan 16, 2025
1 parent 8f5f55d commit 171863f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion pages/admin/PersonImportView.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { ComboBox } from '../../elements/ComboBox';
export class PersonImportViewPage {
readonly page: Page;
readonly body: Locator;
readonly personImportCard: Locator;
readonly headlineBenutzerImport: Locator;
readonly schuleSelectInput: Locator;
readonly schuleSelectCombobox: ComboBox;
Expand All @@ -25,6 +26,7 @@ export class PersonImportViewPage {
// Benutzerimport
this.page = page;
this.body = page.locator('body');
this.personImportCard = page.getByTestId('person-import-card');
this.headlineBenutzerImport = page.getByTestId('layout-card-headline');
this.schuleSelectInput = page.getByTestId('schule-select').locator('input');
this.schuleSelectCombobox = new ComboBox(this.page, this.schuleSelectInput,);
Expand All @@ -44,7 +46,6 @@ export class PersonImportViewPage {

public async navigateToPersonManagementView(): Promise<PersonManagementViewPage> {
await this.closeCardButton.click();
await this.confirmUnsavedChangesButton.click();

return new PersonManagementViewPage(this.page);
}
Expand Down
4 changes: 2 additions & 2 deletions tests/Import.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ test.describe(`Testfälle für den Benutzerimport": Umgebung: ${process.env.ENV}
.goToAdministration())
.goToBenutzerImport());

await expect(personImportPage.headlineBenutzerImport).toBeVisible();
await expect(personImportPage.personImportCard).toBeVisible();
});
});

Expand All @@ -57,7 +57,7 @@ test.describe(`Testfälle für den Benutzerimport": Umgebung: ${process.env.ENV}
});
});

test.skip('Als Landesadmin eine CSV-Datei mit Benutzerdaten hochladen und importieren', {tag: [LONG]}, async ({ page }) => {
test('Als Landesadmin eine CSV-Datei mit Benutzerdaten hochladen und importieren', {tag: [LONG]}, async ({ page }) => {
// Der Test ist aktuell rot, wird mit SPSH-1663 gefixed
await test.step('CSV-Datei hochladen, importieren und importierte Daten downloaden', async () => {
// select schule
Expand Down

0 comments on commit 171863f

Please sign in to comment.