Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Cleanup #38

Merged
merged 1 commit into from
Aug 20, 2015
Merged

Code Cleanup #38

merged 1 commit into from
Aug 20, 2015

Conversation

doylejd
Copy link
Contributor

@doylejd doylejd commented Aug 20, 2015

  • Removed logic to have field_formatters control block display.
  • Hard code options of addthis_basic_toolbox and addthis_basic_button for the time being.
  • Issue Refactor AddThis block to allow for extensibility #23 will cover implementing extensibility into the D8 version.

@doylejd
Removed logic to have field_formatters control block display. Hard co…
59810c5 
…de options of addthis_basic_toolbox and addthis_basic_button for the time being.
jenter pushed a commit that referenced this pull request Aug 20, 2015
Merge pull request #38 from doylejd/master
edf4b63 
Code Cleanup
@jenter jenter merged commit edf4b63 into d8-contrib-modules:master Aug 20, 2015
nerdstein
nerdstein reviewed Aug 20, 2015
View reviewed changes
addthis.module
/**
* Implementation to retrieve formatters for a given type of field.
*/
function _addthis_field_info_formatter_field_type($field_type = NULL) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doylejd @nerdstein @jenter