Add messages for repo error #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be great to close my fork. |
Xiphoseer
reviewed
Nov 16, 2021
git_version/templatetags/git_tags.py
Outdated
| repo.__del__() | ||
| return chash | ||
| except Exception: | ||
| print(f"git_version - trouble with repo path {path}") |
There was a problem hiding this comment.
Suggested change
| print(f"git_version - trouble with repo path {path}") | |
| logger.debug(f"Failed to find current commit for {path}") |
Can you replace the print statement with a logger call as described in https://docs.djangoproject.com/en/3.2/topics/logging/#using-logging? That's probably more appropriate for something published as a library.
Just for the sake of completeness, this would also need
import logging
logger = logging.getLogger(__name__)somewhere at the start of the file
git_version/templatetags/git_tags.py
Outdated
| chash = commit.hexsha | ||
| repo.__del__() | ||
| return chash | ||
| except Exception: |
There was a problem hiding this comment.
Suggested change
| except Exception: | |
| except Exception as e: |
Is there a specific reason not to print the actual exception message? Was that too verbose?
|
Yesterday spotted your message, and updated as requested. |
|
bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a working app is plopped into a container, there is no .git dir, so the Repo() access raises an exception.
This prints a minimal error message, and a clue to the UI why the commit may not show.