Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: simplifying the function readXYZ #36

Merged
merged 3 commits into from
Jul 6, 2023
Merged

ENH: simplifying the function readXYZ #36

merged 3 commits into from
Jul 6, 2023

Conversation

RuhiRG
Copy link
Member

@RuhiRG RuhiRG commented Jul 5, 2023

Partially addresses #35.

@RuhiRG RuhiRG requested review from amritagos and HaoZeke as code owners July 5, 2023 23:47
HaoZeke
HaoZeke approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @RuhiRG, perhaps we can go over refactoring this further later this week.

src/seams_input.cpp Outdated Show resolved Hide resolved
src/seams_input.cpp Outdated Show resolved Hide resolved
@HaoZeke HaoZeke merged commit b00eafa into d-SEAMS:main Jul 6, 2023
@RuhiRG RuhiRG deleted the fixup branch July 13, 2023 22:46
@RuhiRG RuhiRG mentioned this pull request Jul 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoZeke HaoZeke HaoZeke approved these changes

@amritagos amritagos Awaiting requested review from amritagos amritagos is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RuhiRG @HaoZeke