Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add a basic test #3

Merged
merged 22 commits into from
Jun 30, 2024
Merged

CI: Add a basic test #3

merged 22 commits into from
Jun 30, 2024

Conversation

RuhiRG
Copy link
Member

@RuhiRG RuhiRG commented Jul 26, 2023

First attempt.

@RuhiRG RuhiRG requested a review from HaoZeke July 26, 2023 00:11
@RuhiRG RuhiRG self-assigned this Jul 26, 2023
RuhiRG added 18 commits July 1, 2024 02:45
@RuhiRG
CI: Add a basic test
9d0eff8
@RuhiRG
ENH: build_test.yml file
ce065c8
@RuhiRG
ENH: once more
b19c7cf
@RuhiRG
ENH: added fmt as a dependency
95ce966
@RuhiRG
ENH: updated the latest link
eac5053
@RuhiRG
ENH: once more
802fc8c
@RuhiRG
ENH: assigned fmt==9.0.0
c5560e8
@RuhiRG
ENH: regarding seams-core version and keepAxialRingsOnly function
e8a3cd0
@RuhiRG
ENH: revised revision key
dfb8a7a
@RuhiRG
ENH: once more
435697f
@RuhiRG
ENH: bindings for "Structure determination block for ONE-DIMENSIONAL …
a5b31d5 
…ICE"
@RuhiRG
ENH: fixing up for argument order.
7815c9f
@RuhiRG
ENH: pybinds for example monolayer
4fc416a
@RuhiRG
ENH: pybind for example bulkPrimitiveRings
dcb9edc
@RuhiRG
BUG: pybind for example bulkTopologicalCriterion
2dbb6d0
@RuhiRG
ENH: To allign the cpp standard in pyseams and seams-core to 14.
aab75b0
@RuhiRG
ENH: functions needed for the example chillPlus.
a7cc90e
@RuhiRG
ENH: python bindings for chillPlus example
4915100
@RuhiRG RuhiRG force-pushed the addCI branch 2 times, most recently from 32d0202 to 62fa6e2 Compare June 30, 2024 21:28
HaoZeke
HaoZeke requested changes Jun 30, 2024
View reviewed changes
Copy link
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor merge cruft aside, this looks great.

.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
RuhiRG and others added 2 commits July 1, 2024 03:05
@RuhiRG @HaoZeke
MAINT: Update .gitignore
639db9a 
Co-authored-by: Rohit Goswami <[email protected]>
@RuhiRG @HaoZeke
MAINT: Update .gitignore
9f42187 
Co-authored-by: Rohit Goswami <[email protected]>
@RuhiRG RuhiRG requested a review from HaoZeke June 30, 2024 21:36
@HaoZeke HaoZeke added the gsoc24 label Jun 30, 2024
@HaoZeke HaoZeke merged commit 58b65bd into main Jun 30, 2024
1 check passed
@HaoZeke
Copy link
Member

HaoZeke commented Jun 30, 2024

Excellent, thanks @RuhiRG.

@HaoZeke HaoZeke deleted the addCI branch June 30, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoZeke HaoZeke HaoZeke approved these changes

Assignees

@RuhiRG RuhiRG

Labels
gsoc24
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RuhiRG @HaoZeke