Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment module/subpackage #98

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

AhmetCanSolak
Copy link
Contributor

Upon discussion with @xiyuyi about alignment needs(summary can be found in #96 ), in this PR I wanted to discuss and implements the needed APIs and make our alignment work easier and lighter.

@AhmetCanSolak AhmetCanSolak self-assigned this May 31, 2022
@AhmetCanSolak AhmetCanSolak marked this pull request as ready for review June 6, 2022 22:38
@AhmetCanSolak AhmetCanSolak requested a review from xiyuyi June 9, 2022 19:10
Copy link

@xiyuyi xiyuyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure appear useful at the current stage. Before merging, perhaps having a collection of more intuitive demo or test codes would be helpful.

We would also need the API the following devices:
Motorized actuator from Thorlabs.
Hamamatsu camera.
Motorized stage (ASI).
Thorlabs inspection camera (sCMOS).

@AhmetCanSolak
Copy link
Contributor Author

The structure appear useful at the current stage. Before merging, perhaps having a collection of more intuitive demo or test codes would be helpful.

We would also need the API the following devices: Motorized actuator from Thorlabs. Hamamatsu camera. Motorized stage (ASI). Thorlabs inspection camera (sCMOS).

We already have what is needed for ASI stage and hamamatsu camera(can make the final API nicer though). For the Thorlabs devices, could you share the specific devices you want to use @xiyuyi ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants