-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alignment module/subpackage #98
base: main
Are you sure you want to change the base?
Alignment module/subpackage #98
Conversation
…ot into alignment-subpackage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structure appear useful at the current stage. Before merging, perhaps having a collection of more intuitive demo or test codes would be helpful.
We would also need the API the following devices:
Motorized actuator from Thorlabs.
Hamamatsu camera.
Motorized stage (ASI).
Thorlabs inspection camera (sCMOS).
We already have what is needed for ASI stage and hamamatsu camera(can make the final API nicer though). For the Thorlabs devices, could you share the specific devices you want to use @xiyuyi ? |
…ot into alignment-subpackage
Upon discussion with @xiyuyi about alignment needs(summary can be found in #96 ), in this PR I wanted to discuss and implements the needed APIs and make our alignment work easier and lighter.