adding laser base and voltran stradus laser module #148
Conversation
|
I see you've written this to use the RS-232 connection. These are quite outdated at this point, and would limit the usability of this device. It would also be hard to connect multiple lasers to the same workstation. I would encourage you to use the USB interface instead. |
There was a problem hiding this comment.
Great work @edyoshikun ! Thank you for the PR, dropped some comments for the first iteration.
|
@ieivanov I agree with you and will implement it in the second iteration. At the moment, I am waiting for Voltran to provide us with more documentation on the USB side. There seems to be something blocking me from writing to it, so for testing and debugging to keep us moving forward, the RS-232 implementation works well. |
There was a problem hiding this comment.
Thank you for addressing all comments @edyoshikun , if you are happy with your tests we can go ahead and merge this PR! (after it passes the CI)
|
@AhmetCanSolak I added more tests and it all looks good. I saw some flake8 issues but wasn't quite sure what was 'best practices' way to fix them was. |
| Laser Drive Control Mode | ||
| Sets Power or Current Control | ||
| (1 = Current Control) | ||
|
|
There was a problem hiding this comment.
Could you provide the value use for power control?
Passing CI is enough for now but CI is currently failing, please address the style and lint issues before we merge this PR. |
There was a problem hiding this comment.
@edyoshikun please check and test the implementation after my refactor and let me know if I broke anything
|
Just tested this physically the demos worked like a charm. Thank you @AhmetCanSolak for the refactoring. |
This adds the abstract base class for lasers and the implementation of the voltran stradus laser for photom.
This addresses the laser requirement for #146