Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysqldump-secure: documentation and multi-php fix. #995

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

userwiths
Copy link

Fixes for issue #985

PR contains two commits, one only for documentation, one for yml fix, both are related to the same issue.

Goal

Improve documentation and prevent future misunderstandings due to the user being unaware of certain variables.
Add missing mounts for the multi PHP setup.

Description

Documentation Commit

The following variables:

  • MYSQL_BACKUP_USER
  • MYSQL_BACKUP_PASS
  • MYSQL_BACKUP_HOST

Are used for generating the mysqldump-secure configuration file as can be seen here
In case they are missing from the .env file, the mysqldump-secure command cannot be run successfully on containers other than the default one due to different username/password.

Multi PHP issue

Here the issue was that the backups directory was not mounting to the given container, probably because of the missing declaration. Was added and tested, now mysqldump-secure should be able to write to the host directory regardless from which container it is started.

* `MYSQL_BACKUP_USER`
* `MYSQL_BACKUP_PASS`
* `MYSQL_BACKUP_HOST`

In case they are missing from the `.env` file, the `mysqldump-secure` command cannot be run successfully on
containers other than the default one.
[Related piece of code](https://github.com/devilbox/docker-php-fpm/blob/042023514ddb26289f7fe7565dc03eadfdc56bff/Dockerfiles/slim/data/docker-entrypoint.sh#L191) which is responsible for the generation of the mysqldump-secure configuration file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant