jmap_contact.c: base64url encode vCard UIDs as JMAP ids #5169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksmurchison
force-pushed
the
cyr-1419-jmap_contact_ids
branch
from
ed6f4cc to
596f116
Compare
wolfsage
reviewed
Dec 13, 2024
| @@ -11265,8 +11294,10 @@ static int _card_set_create(jmap_req_t *req, | |||
| static int maxattempts = 3; | |||
| int i; | |||
| for (i = 0; i < maxattempts; i++) { | |||
| struct buf buf = BUF_INITIALIZER; | |||
| buf_printf(&buf, "urn:uuid:%s", makeuuid()); | |||
There was a problem hiding this comment.
With urn:uuid in the uid, we'll always end up picking a different resource name below since ':' isn't one of the valid characters. Is this desirable/expected?
|
@ksmurchison I removed myself as reviewer while this is a draft. Please re-add me for review when it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents us from return "urn:uuid:xxx" as an object id, but also allows us to derive the vCard UID from the object id to avoid any changes to dav.db