Twom database format and first implementation #5157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brong
force-pushed
the
twom
branch
2 times, most recently
from
2a4c0a9 to
74d9e42
Compare
|
I've removed include-in-fm while tests are failing. |
brong
force-pushed
the
twom
branch
4 times, most recently
from
7d3b303 to
5ffbf60
Compare
brong
requested review from
dilyanpalauzov,
robmueller,
rjbs,
elliefm,
wolfsage and
rsto
and removed request for
dilyanpalauzov
brong
force-pushed
the
twom
branch
2 times, most recently
from
981f5c7 to
a0615b2
Compare
|
Bah, CI failed because |
elliefm
reviewed
Jan 6, 2025
brong
force-pushed
the
twom
branch
5 times, most recently
from
17f965c to
0e6615f
Compare
Thanks! yeah, there were more issues but I believe it's all clean now! |
|
OK! Major messing around.
|
brong
force-pushed
the
twom
branch
2 times, most recently
from
9d3e467 to
4592a4a
Compare
This is all awful and I'm going to ask Ken to add basecid in the next index format change!
This contains the full implementation of the xxhash algorithm. It's only being used by twom database format, so it's being compiled straight into that file. This is an unmodified copy of xxhash.h from: commit dd11140c2dc5d53a3c0a949d67af7f40f546878e in the repository at [email protected]:Cyan4973/xxHash.git
brong
force-pushed
the
twom
branch
5 times, most recently
from
e6cf33a to
1520f4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throwing this open for wide reviews now! It's been rewritten a BUNCH of times, and optimised a fair bit - it's got a simpler internal structure and basically everything aligned with the right datastructures I think. It does MVCC reads nicely, can keep its transaction in foreach unless the callback writes, in which case it STILL does the right thing and re-locks and re-finds itself.
On disk format of records is:
