Move buf_ declarations to a separate, installed .h file #5108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because sieve_intefrace.h depends on struct buf declaration and sieve_interface.h is installed. -- install libconfig.h, imap/message_guid.h -- charset.h (installed): do not depend on util.h and thus on config.h
dilyanpalauzov
force-pushed
the
buf_declarations
branch
from
ab67d89 to
1f2cd8e
Compare
|
This looks fine. Is there any reason why you didn't also split the buf function implememtations into their own buf.c source file? |
|
The reason is that this is more work. |
dilyanpalauzov
added a commit
to dilyanpalauzov/cyrus-imapd
that referenced
this pull request
Nov 10, 2024
cyrusimap#5108 because sieve_intefrace.h depends on struct buf declaration and sieve_interface.h is installed. -- install libconfig.h, imap/message_guid.h -- charset.h (installed): do not depend on util.h and thus on config.h
dilyanpalauzov
added a commit
to dilyanpalauzov/cyrus-imapd
that referenced
this pull request
Nov 10, 2024
cyrusimap#5108 because sieve_intefrace.h depends on struct buf declaration and sieve_interface.h is installed. -- install libconfig.h, imap/message_guid.h -- charset.h (installed): do not depend on util.h and thus on config.h
dilyanpalauzov
added a commit
to dilyanpalauzov/cyrus-imapd
that referenced
this pull request
Nov 11, 2024
because sieve_intefrace.h depends on struct buf declaration and sieve_interface.h is installed. -- install libconfig.h, imap/message_guid.h -- charset.h (installed): do not depend on util.h and thus on config.h cyrusimap#5108
dilyanpalauzov
added a commit
to dilyanpalauzov/cyrus-imapd
that referenced
this pull request
Nov 11, 2024
because sieve_intefrace.h depends on struct buf declaration and sieve_interface.h is installed. -- install libconfig.h, imap/message_guid.h -- charset.h (installed): do not depend on util.h and thus on config.h cyrusimap#5108
dilyanpalauzov
added a commit
to dilyanpalauzov/cyrus-imapd
that referenced
this pull request
Nov 13, 2024
because sieve_intefrace.h depends on struct buf declaration and sieve_interface.h is installed. -- install libconfig.h, imap/message_guid.h -- charset.h (installed): do not depend on util.h and thus on config.h cyrusimap#5108
dilyanpalauzov
added a commit
to dilyanpalauzov/cyrus-imapd
that referenced
this pull request
Nov 14, 2024
because sieve_intefrace.h depends on struct buf declaration and sieve_interface.h is installed. -- install libconfig.h, imap/message_guid.h -- charset.h (installed): do not depend on util.h and thus on config.h cyrusimap#5108
dilyanpalauzov
added a commit
to dilyanpalauzov/cyrus-imapd
that referenced
this pull request
Nov 14, 2024
cyrusimap#5108 because sieve_intefrace.h depends on struct buf declaration and sieve_interface.h is installed. -- install libconfig.h, imap/message_guid.h -- charset.h (installed): do not depend on util.h and thus on config.h
dilyanpalauzov
added a commit
to dilyanpalauzov/cyrus-imapd
that referenced
this pull request
Nov 14, 2024
cyrusimap#5108 because sieve_intefrace.h depends on struct buf declaration and sieve_interface.h is installed. -- install libconfig.h, imap/message_guid.h -- charset.h (installed): do not depend on util.h and thus on config.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because sieve_intefrace.h depends on
struct bufdeclaration and sieve_interface.h is installed.-- install libconfig.h, imap/message_guid.h
-- charset.h (installed): do not depend on util.h and thus on config.h