util.c: bug fix: xsyslog_ev_escape_value learns to always quote the e…

…mpty string And regression test
cyrusimap · Dec 24, 2024 · c4e782a · c4e782a
1 parent 00a89e6
commit c4e782a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/cunit/util.testc b/cunit/util.testc
@@ -93,6 +93,7 @@ static void test_xsyslog_ev_escape_value(void)
          "\r",               "\"\\r\"",
          "\r\n",             "\"\\r\\n\"",
          "-12.345e67",       "-12.345e67",
+         "",                 "\"\"",
          NULL,
      };
 

diff --git a/lib/util.c b/lib/util.c
@@ -2448,6 +2448,7 @@ static const char *xsyslog_ev_escape_value(struct buf *val)
     const char *p;
 
     escaped_len = orig_len = buf_len(val);
+    if (orig_len == 0) { return "\"\""; } // Make sure the empty string is visible
 
     for (p = buf_cstring(val); *p; p++) {
         switch (*p) {