[DRAFT] dependency: Electron update (38)

[jennifer-shehane]

• Closes

Additional details

Steps to test

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

---

Note

Upgrade Electron to 38.5.0 and sync Node 22.20.0 across repo, updating CI images, system test Docker tags, and prebuild/ABI settings.

• Dependencies:
  • Upgrade electron to 38.5.0 in root package.json; update node-abi resolution to 4.17.0.
  • Bump Node engine to >=22.20.0; update .node-version and .nvmrc to 22.20.0.
  • Update @types/node to 22.19.0 across packages.
• CI/CD & Docker:
  • Switch CircleCI base images to cypress/base-internal:22.20.0-* (@pipeline.yml); update better-sqlite3 builder image and prebuild target to -t 38.5.0.
  • Add workflow branch filter electron-bump-version in workflows/@main.yml.
  • Update docker-compose.yml CI image to cypress/base-internal:22.20.0-trixie.
• System Tests:
  • Update Docker image tags to 22.20.0 in system-tests/test-binary/*.
• Tooling/Docs:
  • Minor wording fixes and simplified changelog bullets in packages/electron/.cursor/rules/electron-upgrade.mdc.

^{Written by Cursor Bugbot for commit e95bd53. This will update automatically on new commits. Configure here.}

[cursor]

Bug: Inconsistent Branch Name Breaks Artifact Persistence

The workflow filter in @main.yml was changed from 'chore/remove_unused_anchors' to 'electron-bump-version', but the setup_should_persist_artifacts command still references the old branch name 'chore/remove_unused_anchors'. This inconsistency means artifacts will persist for the old branch name but not for the new 'electron-bump-version' branch, breaking the intended workflow behavior.

.circleci/src/pipeline/@pipeline.yml#L118-L119

cypress/.circleci/src/pipeline/@pipeline.yml

Lines 118 to 119 in e95bd53

	echo "Setting SHOULD_PERSIST_ARTIFACTS variable"
	echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "chore/remove_unused_anchors" ]]; then

 

---