Skip to content

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Oct 17, 2025

  • Closes

Additional details

converts the @packages/net-stubbing tests from mocha to vitest. Conversion was mostly 1:1

Steps to test

How has the user experience changed?

PR Tasks


Note

Migrates @packages/net-stubbing unit tests to Vitest, updates package scripts/config, adjusts CI test-results count, and marks migration complete in docs.

  • Tests (@packages/net-stubbing):
    • Convert unit tests from Mocha/Chai/Sinon to Vitest in test/unit/*.spec.ts (use describe/it/expect, vi.fn, and toEqual/toMatchObject, etc.).
    • Add Vitest config: packages/net-stubbing/vitest.config.ts (Node env, globals, includes, CYPRESS_INTERNAL_ENV=test).
  • Package Configuration:
    • packages/net-stubbing/package.json:
      • Replace Mocha test script with vitest; add test-watch and test-debug.
      • Remove mocha/chai dev deps; add vitest.
  • CI:
    • .circleci/src/pipeline/@pipeline.yml: reduce sanitize-verify-and-store-mocha-results.expectedResultCount from 7 to 6 in unit-tests job.
  • Docs:
    • guides/esm-migration.md: mark packages/net-stubbing as ✅ completed under Phase 2.

Written by Cursor Bugbot for commit 398aa65. This will update automatically on new commits. Configure here.

@AtofStryker AtofStryker self-assigned this Oct 17, 2025
@AtofStryker AtofStryker merged commit 096b756 into develop Oct 20, 2025
88 of 94 checks passed
@AtofStryker AtofStryker deleted the chore/net-stubbing-vitest-wip branch October 20, 2025 17:24
cypress-app-bot pushed a commit that referenced this pull request Oct 21, 2025
cypress-app-bot pushed a commit that referenced this pull request Oct 21, 2025
cypress-app-bot pushed a commit that referenced this pull request Oct 21, 2025
cypress-app-bot pushed a commit that referenced this pull request Oct 21, 2025
cypress-app-bot pushed a commit that referenced this pull request Oct 21, 2025
cypress-app-bot pushed a commit that referenced this pull request Oct 21, 2025
jennifer-shehane pushed a commit that referenced this pull request Oct 21, 2025
* chore: updating v8 snapshot cache

* index on develop: 93375b7 fix: ensure that the text alignment for grouped command logs is consistent (#32757)

* index on develop: 93375b7 fix: ensure that the text alignment for grouped command logs is consistent (#32757)

* index on develop: 096b756 chore: convert @packages/net-stubbing tests to vitest from mocha (#32758)

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
jennifer-shehane pushed a commit that referenced this pull request Oct 21, 2025
* chore: updating v8 snapshot cache

* index on develop: 93375b7 fix: ensure that the text alignment for grouped command logs is consistent (#32757)

* index on develop: 93375b7 fix: ensure that the text alignment for grouped command logs is consistent (#32757)

* index on develop: 096b756 chore: convert @packages/net-stubbing tests to vitest from mocha (#32758)

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
jennifer-shehane pushed a commit that referenced this pull request Oct 21, 2025
* chore: updating v8 snapshot cache

* index on develop: 93375b7 fix: ensure that the text alignment for grouped command logs is consistent (#32757)

* index on develop: 93375b7 fix: ensure that the text alignment for grouped command logs is consistent (#32757)

* index on develop: 096b756 chore: convert @packages/net-stubbing tests to vitest from mocha (#32758)

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
pull bot pushed a commit to xjc90s/cypress that referenced this pull request Oct 21, 2025
* chore: updating v8 snapshot cache

* index on develop: 93375b7 fix: ensure that the text alignment for grouped command logs is consistent (cypress-io#32757)

* index on develop: 93375b7 fix: ensure that the text alignment for grouped command logs is consistent (cypress-io#32757)

* index on develop: 096b756 chore: convert @packages/net-stubbing tests to vitest from mocha (cypress-io#32758)

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants