Skip to content

spike: built in removal #31643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

AtofStryker
Copy link
Contributor

  • Closes

Additional details

Steps to test

How has the user experience changed?

PR Tasks

Copy link

cypress bot commented May 5, 2025

cypress    Run #62520

Run Properties:  status check failed Failed #62520  •  git commit 13464eb8eb: remove certain built-ins from the preprocessor and see what breaks
Project cypress
Branch Review spike/built-in-removal
Run status status check failed Failed #62520
Run duration 15m 56s
Commit git commit 13464eb8eb: remove certain built-ins from the preprocessor and see what breaks
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 589
View all changes introduced in this branch ↗︎
UI Coverage  0%
  Untested elements 4  
  Tested elements 0  
Accessibility  97.09%
  Failed rules  0 critical   1 serious   0 moderate   0 minor
  Failed elements 4  

Tests for review

Failed  cypress/e2e/studio/studio.cy.ts • 1 failed test • app-e2e

View Output

Test Artifacts
Cypress Studio > cloud studio > opens a cloud studio session with AI enabled Test Replay Screenshots
Flakiness  studio/studio.cy.ts • 2 flaky tests • app-e2e

View Output

Test Artifacts
Cypress Studio > remains in studio mode when the test name is changed on the file system and file watching is disabled Test Replay Screenshots
Cypress Studio > does not remove the studio url parameters if saving fails Test Replay Screenshots
Flakiness  top-nav.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
... > with no project id > shows "connect project" button after login if no project id is set Test Replay Screenshots

@AtofStryker AtofStryker force-pushed the spike/built-in-removal branch 2 times, most recently from a5fc24d to d1b72e4 Compare May 6, 2025 01:37
@AtofStryker AtofStryker force-pushed the spike/built-in-removal branch 7 times, most recently from 87859af to 80cf178 Compare May 19, 2025 14:28
Remove ALL built ins and see what falls over
@AtofStryker AtofStryker force-pushed the spike/built-in-removal branch from 80cf178 to 13464eb Compare May 19, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant