Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(other): jmap quota display #1296

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

Shadow243
Copy link
Member

@Shadow243 Shadow243 commented Oct 22, 2024

RFC: https://www.rfc-editor.org/rfc/rfc9425.pdf
Add get_quota_root to hm-jmap.php to correct error Uncaught Error: Call to undefined method Hm_JMAP::get_quota_root
Screenshot 2024-10-22 at 18 15 28

@Shadow243
Copy link
Member Author

There an other issue that i'l correct: Uncaught Error: Call to undefined method Hm_JMAP::get_capability()

@Shadow243 Shadow243 marked this pull request as draft October 22, 2024 17:21
@Shadow243 Shadow243 force-pushed the fix-jmap-quota branch 3 times, most recently from d97d6da to c5b5205 Compare October 23, 2024 19:19
@Shadow243 Shadow243 marked this pull request as ready for review October 23, 2024 19:19
@Shadow243
Copy link
Member Author

There an other issue that i'l correct: Uncaught Error: Call to undefined method Hm_JMAP::get_capability()

I just added get_capability that must be implemented, I just spent several hours on this but no method worked, so I have to look for another way.

@Baraka24 Baraka24 requested a review from kroky November 22, 2024 11:45
@Shadow243 Shadow243 changed the title [FIX] Fixed jmap quota display fix(other): jmap quota display Nov 23, 2024
@marclaporte
Copy link
Member

@kroky all good?

@kroky kroky merged commit b05c1d7 into cypht-org:master Dec 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants