Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep favorite weather stations #523

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jamez70
Copy link
Contributor

@jamez70 jamez70 commented Nov 16, 2016

Remembers weather stations in the favorite list which does not clear when leaving the weather page

@cyoung
Copy link
Owner

cyoung commented Nov 16, 2016

At this point I've only looked through the Go portion, but the []watchedStationType could have some thread concurrency issues.

Could we change the /weatherwatched ws to work more like the /traffic ws, where the current traffic is sent then only changes are sent (versus re-sending all the watched weather reports every 5 seconds)?

@jamez70
Copy link
Contributor Author

jamez70 commented Nov 16, 2016

Possibly. I had originally had it only send if there was a change, but then when you navigate to the web page you will have no data. Then, I attempted to send when the websocket was connected, then only after a change and that did not work very well either. The problem is if you leave and reopen the web page it does not have any data and would need all of the data in order to display it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants