Repository navigation
Apply the configuration bundled in a pipeline file as the lowest argument layer - #66
Merged
Merged
Conversation
…ment layer The .adg carries its values in configs[0], in the arguments-file shape. adagio run reads it under --arguments and flags, --no-bundled-config ignores it, adagio pipeline config prints it, and the adapter-facing runtime command applies it under the job's arguments. Signatures no longer carry defaults; older files that do are read the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A
.adgnow carries its values in aconfigslist (see adagio-appfeat/adg-configs), in the arguments-file shape. The CLI applies the first bundled config as the lowest layer:.adg--argumentsfileadagio runreads it under--argumentsand flags;--helpand--show-paramsresolve defaults and "missing" through the same layers.--no-bundled-configignores it (Nextflow's-Cfor this file).adagio pipeline config <pipeline>prints the bundled config as an arguments file to save, edit and pass back.adagio runtime --spec(adapter path) applies it under the job's arguments when the spec file is a full envelope.requireddefaults totrue); files written before configs existed still supplysignature.parameters[].defaultandmeta.editor_variables[].valueas a bundled config.--argumentsfile are still errors.Tests
271 passed; new
tests/test_bundled_config.pycovers precedence, the flag, legacy lift, unused-variable tolerance, theconfigcommand and the runtime path.