Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstrings, refactor process_query, and move AsyncTimeoutError to gitingest.exceptions #77

Conversation

filipchristiansen
Copy link
Collaborator

@filipchristiansen filipchristiansen commented Dec 30, 2024

This PR introduces two main changes:

  1. Adds docstrings to various functions to improve code documentation and readability.
  2. Moves the main function process_query to the top of the process_query.py file for better organization.
  3. Prefixes helper functions with an underscore to follow Python naming conventions for internal functions.
  4. Moves the AsyncTimeoutError exception to the gitingest.exceptions module for better exception handling organization.

These changes enhance code clarity, maintainability, and adhere to best practices in Python code organization and exception management.

@filipchristiansen filipchristiansen changed the title Add docstrings and refactor: Move AsyncTimeoutError to gitingest.exceptions Add docstrings, refactor process_query, and move AsyncTimeoutError to gitingest.exceptions Dec 30, 2024
Copy link
Owner

@cyclotruc cyclotruc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the new docstrings are very much welcome

@cyclotruc cyclotruc merged commit fab90a6 into cyclotruc:main Dec 30, 2024
12 checks passed
@filipchristiansen filipchristiansen deleted the add-docstrings-move-AsyncTimeoutError branch December 30, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants