-
Notifications
You must be signed in to change notification settings - Fork 766
Add "cyctl helm migrate" command to batch-migrate Helm releases to Cyclops Modules #864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…in this command cyctl helm migrate --namespace <name of the release> --repo <template repo> --path <template path> --version <version>
… helm release name and cluster namespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 🧡
I left a comment on reusing the Kubernetes client from cyclops-ctrl/pkg. Also, migrating the whole namespace at once sounds a bit risky. Can we require users to provide a list of releases they want to migrate?
|
||
"github.com/cyclops-ui/cyclops/cyclops-ctrl/api/v1alpha1" | ||
cyclopsclient "github.com/cyclops-ui/cyclops/cyclops-ctrl/api/v1alpha1/client" | ||
"github.com/cyclops-ui/cycops-cyctl/utility" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the Kubernetes client from cyclops-ctrl/pkg instead? This way, you don't have to reimplement the utility package
cyctl/go.mod
Outdated
module github.com/cyclops-ui/cycops-cyctl | ||
|
||
go 1.22.0 | ||
go 1.24.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert to the previous version of Go and other dependencies unless crucial?
@petar-cvit Thank you for the feedback. I'll be working on the requested changes and push the refactored version. |
@petar-cvit I have made the required changes and updated the PR description, you can check again. |
closes #747
📑 Description
What this PR does / Why we need it
This PR introduces a new CLI command
cyctl helm migrate
to automate migration of existing Helm releases within a namespace to Cyclops Modules.By running,
cyctl helm migrate --namespace <ns> --releases <release-name or list of releases> --repo <template repo> --path <template path> --version <version>
The system will :
repo/path@version
.✅ Checks
Before Migrating:
Run cmd to migrate helm release to Cyclops Module:

Migrated helm release to Cyclops Module:


Additional context
PR Type
/kind feature