Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor View Manifest modal #649

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ const ResourceList = ({
});
const [deleteResourceVerify, setDeleteResourceVerify] = useState("");

//for fetchManifest function
const [loadingResourceManifest, setLoadingResourceManifest] = useState(false);

const [showManagedFields, setShowManagedFields] = useState(false);

const [resourceFilter, setResourceFilter] = useState<string[]>([]);
Expand Down Expand Up @@ -161,34 +164,40 @@ const ResourceList = ({
};

function fetchManifest(
group: string,
version: string,
kind: string,
namespace: string,
name: string,
showManagedFields: boolean,
) {
axios
.get(`/api/manifest`, {
params: {
group: group,
version: version,
kind: kind,
name: name,
namespace: namespace,
includeManagedFields: showManagedFields,
},
})
.then((res) => {
setManifestModal((prev) => ({
...prev,
manifest: res.data,
}));
})
.catch((error) => {
setError(mapResponseError(error));
});
}
group: string,
version: string,
kind: string,
namespace: string,
name: string,
showManagedFields: boolean,
) {
setLoadingResourceManifest(true);

axios
.get(`/api/manifest`, {
params: {
group: group,
version: version,
kind: kind,
name: name,
namespace: namespace,
includeManagedFields: showManagedFields,
},
})
.then((res) => {
setManifestModal((prev) => ({
...prev,
manifest: res.data,
}));
})
.catch((error) => {
console.error("Failed to fetch resource manifest:", error);
setError(mapResponseError(error));
})
.finally(() => {
setLoadingResourceManifest(false);
});
}

const resourceFilterOptions = () => {
if (!loadResources) {
Expand Down Expand Up @@ -631,22 +640,16 @@ const ResourceList = ({
<Modal
title="Manifest"
open={manifestModal.on}
onOk={handleCancelManifest}
onCancel={handleCancelManifest}
cancelButtonProps={{ style: { display: "none" } }}
footer={null} // Removed the OK button
width={"70%"}
>
<Checkbox onChange={handleCheckboxChange} checked={showManagedFields}>
Include Managed Fields
</Checkbox>
<Divider style={{ marginTop: "12px", marginBottom: "12px" }} />
<div style={{ position: "relative" }}>
<ReactAce
style={{ width: "100%" }}
mode={"sass"}
value={manifestModal.manifest}
readOnly={true}
/>
{moduleManifestContent(manifestModal.manifest, loadingResourceManifest)}
<Tooltip title={"Copy Manifest"} trigger="hover">
<Button
onClick={() => {
Expand Down