Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: updated the displaying of the namespace #606

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

Abiji-2020
Copy link
Contributor

@Abiji-2020 Abiji-2020 commented Oct 4, 2024

closes #599

πŸ“‘ Description

In the command line cyctl get resources updated to display the Namespace of the deployed modules.

βœ… Checks

  • I have tested my code (provide screenshots or screen recordings of a working solution)
  • I have performed a self-review of my code

β„Ή Additional context

@quest-bot loot #599

image

@Abiji-2020 Abiji-2020 requested a review from a team as a code owner October 4, 2024 08:58
@Abiji-2020
Copy link
Contributor Author

@quest-bot loot #599

@quest-bot quest-bot bot added the βš”οΈ Quest Tracks quest-bot quests label Oct 4, 2024
Copy link

quest-bot bot commented Oct 4, 2024

Quest PR submitted! image Quest PR submitted!

@Abiji-2020, you are attempting to solve the issue and loot this Quest. Will you be successful?


Questions? Check out the docs.

@Abiji-2020
Copy link
Contributor Author

@petar-cvit any reviews on the PR?

Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it on a module created from the rabbitmq template and the output was the following

./cyctl get resources rabbit
KIND                 NAME                 NAMESPACE
Secret               rabbit-rabbitmq     default
Secret               rabbit-rabbitmq-configdefault
Service              rabbit-rabbitmq     default
Service              rabbit-rabbitmq-headlessdefault
ServiceAccount       rabbit-rabbitmq     default
StatefulSet          rabbit-rabbitmq     default
NetworkPolicy        rabbit-rabbitmq     default
PodDisruptionBudget  rabbit-rabbitmq     default
Role                 rabbit-rabbitmq-endpoint-readerdefault
RoleBinding          rabbit-rabbitmq-endpoint-readerdefault

Can you replace name and namespace columns? Also make sure to calculate the longest value in the column so you know how much space is needed between columns (in the example above name and namespace columns are not properly separated).

…of 2 extra spaces after the end of the length for better visibility

Signed-off-by: Abinand P <[email protected]>
@Abiji-2020
Copy link
Contributor Author

After updating

image

Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Abiji-2020 🧑 Looks much more simple

@petar-cvit petar-cvit merged commit a56454d into cyclops-ui:main Oct 8, 2024
1 check passed
@Abiji-2020
Copy link
Contributor Author

@petar-cvit could you approve the reward for this quest ?

Copy link

quest-bot bot commented Oct 10, 2024

🧚 @Abiji-2020 congratulations for completing Quest #599

πŸ’° A reward has been credited to you.

To claim your reward follow the instructions here.

Questions? Check out the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
βš”οΈ Quest Tracks quest-bot quests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cyctl get resources missing namespace
2 participants