Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcilation command line #595

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

Abiji-2020
Copy link
Contributor

@Abiji-2020 Abiji-2020 commented Sep 29, 2024

closes #586

πŸ“‘ Description

created a function in Cobra and added in the root command running cyctl reconcile <module name> will reconcile the specified module;

βœ… Checks

  • I have tested my code (provide screenshots or screen recordings of a working solution)
  • I have performed a self-review of my code

The reconcilation file
@Abiji-2020 Abiji-2020 requested a review from a team as a code owner September 29, 2024 13:49
Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abiji-2020 thanks for the PR! Let a couple of comments on cli output, but looks good

cyctl/cmd/reconcile.go Outdated Show resolved Hide resolved
cyctl/cmd/reconcile.go Outdated Show resolved Hide resolved
cyctl/cmd/reconcile.go Outdated Show resolved Hide resolved
@Abiji-2020
Copy link
Contributor Author

@petar-cvit The requested changes on the outputs of the cli have been updated

Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Abiji-2020 🧑

@petar-cvit petar-cvit merged commit 498c225 into cyclops-ui:main Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cyctl reconcile module command
2 participants