Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploy modules to different namespaces #381

Closed
wants to merge 6 commits into from
Closed

feat: deploy modules to different namespaces #381

wants to merge 6 commits into from

Conversation

hanshal101
Copy link
Contributor

CLOSES #201
FIXES #201

πŸ“‘ Description

In this PR I have added the functionality to deploy modules to different namespace

βœ… Checks

  • I have updated the documentation as required
  • I have performed a self-review of my code

β„Ή Screenshots

image

  • Here you can see test-ns-module deployed in test namespace
    image

@hanshal101 hanshal101 requested a review from a team as a code owner June 28, 2024 11:06
@petar-cvit
Copy link
Collaborator

Hey @hanshal101, what do you think about adding a collapsible section for other options? We could put the namespace option there, but also some other stuff for the future. It will hold all the options for deploying a module besides the name of the module and the values

@hanshal101
Copy link
Contributor Author

Cool will do this

@hanshal101
Copy link
Contributor Author

Hey i'm not able to find and figure how can this be done, can you please help me with this?

@hanshal101
Copy link
Contributor Author

image
Something like this works?

@petar-cvit
Copy link
Collaborator

Instead of Module namespace, you can just have a Collapse that can be called options or something and inside you can set your namespace

@hanshal101
Copy link
Contributor Author

image
Like this?

@petar-cvit
Copy link
Collaborator

You can add options directly under name and remove the Define Module title

@hanshal101
Copy link
Contributor Author

hanshal101 commented Jun 29, 2024

Ohk so the options should render the items?
That are mentioned in the template

@petar-cvit
Copy link
Collaborator

No, I'd have the title Module name and under it name field and options collapse. Under that title Define Module which will have all the fields from the template rendered under it

@hanshal101
Copy link
Contributor Author

hanshal101 commented Jun 29, 2024

image
Just for confirmation

@petar-cvit
Copy link
Collaborator

Yup, that looks good. Can you make the options the same width as the name field?

@hanshal101
Copy link
Contributor Author

I think I messed something here
Can you please help

@hanshal101 hanshal101 closed this Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable deploying Modules in Different Namespaces
2 participants