Update argocd-image-updater version to v0.15.1 #1496
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahiro-yamada
requested changes
Dec 27, 2024
Comment on lines
+21
to
23
| apt-get install -y --no-install-recommends git openssh-client python3 python3-pip tini gpg gpg-agent && \ | ||
| pip3 install --upgrade pip && \ | ||
| pip3 install awscli && \ |
There was a problem hiding this comment.
24.04/ubuntu-debug installs awscli with curl, how about using this method?
With this, we can omit installing python3 and python3-pip I think.
https://github.com/cybozu/ubuntu-base/blob/1cb03b74e6b001c989ea83296a035e1bb9b7d129/24.04/ubuntu-debug/Dockerfile#L55-L58
| LABEL org.opencontainers.image.source="https://github.com/cybozu/neco-containers" | ||
|
|
||
| RUN groupadd -g 10000 argocd && \ | ||
| useradd -r -u 10000 -g argocd argocd && \ | ||
| mkdir -p /home/argocd && \ | ||
| chown argocd:argocd /home/argocd && \ | ||
| apt-get update && \ | ||
| apt-get install -y --no-install-recommends git openssh-client python3 python3-pip && \ | ||
| apt-get install -y --no-install-recommends git openssh-client python3 python3-pip tini gpg gpg-agent && \ | ||
| pip3 install --upgrade pip && \ | ||
| pip3 install awscli && \ | ||
| apt-get clean && \ |
There was a problem hiding this comment.
We can omit explicit apt-get clean.
https://docs.docker.com/build/building/best-practices/
Official Debian and Ubuntu images automatically run apt-get clean, so explicit invocation is not required.
| LABEL org.opencontainers.image.source="https://github.com/cybozu/neco-containers" | ||
|
|
||
| RUN groupadd -g 10000 argocd && \ | ||
| useradd -r -u 10000 -g argocd argocd && \ | ||
| mkdir -p /home/argocd && \ | ||
| chown argocd:argocd /home/argocd && \ | ||
| apt-get update && \ | ||
| apt-get install -y --no-install-recommends git openssh-client python3 python3-pip && \ | ||
| apt-get install -y --no-install-recommends git openssh-client python3 python3-pip tini gpg gpg-agent && \ |
There was a problem hiding this comment.
I think it's better to write package names line by line and alphabetize them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.