-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #286
Merged
Merged
Update dependencies #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morimoto-cybozu
force-pushed
the
update-dependencies
branch
from
November 15, 2024 14:46
4fb3d27
to
6b4b060
Compare
masa213f
requested changes
Nov 22, 2024
CHANGELOG.md
Outdated
Comment on lines
8
to
15
### Changed | ||
|
||
- Update dependencies in [#285](https://github.com/cybozu-go/sabakan/pull/285) | ||
|
||
### Fixed | ||
|
||
- Fix to remove empty asset URL after dedup in [#285](https://github.com/cybozu-go/sabakan/pull/285) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URLs are wrong.
Suggested change
### Changed | |
- Update dependencies in [#285](https://github.com/cybozu-go/sabakan/pull/285) | |
### Fixed | |
- Fix to remove empty asset URL after dedup in [#285](https://github.com/cybozu-go/sabakan/pull/285) | |
### Changed | |
- Update dependencies in [#286](https://github.com/cybozu-go/sabakan/pull/286) | |
### Fixed | |
- Fix to remove empty asset URL after dedup in [#286](https://github.com/cybozu-go/sabakan/pull/286) | |
Signed-off-by: morimoto-cybozu <[email protected]>
Signed-off-by: morimoto-cybozu <[email protected]>
Extend the boot disk size of GCP VM in response to cybozu-go/neco-gcp#153. Signed-off-by: morimoto-cybozu <[email protected]>
Signed-off-by: morimoto-cybozu <[email protected]>
morimoto-cybozu
force-pushed
the
update-dependencies
branch
from
November 22, 2024 06:16
da6cc4d
to
0016b77
Compare
masa213f
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: morimoto-cybozu [email protected]