Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "enable xdp acceleration" #2068

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Revert "enable xdp acceleration" #2068

merged 1 commit into from
Aug 30, 2022

Conversation

ysksuzuki
Copy link
Contributor

@ysksuzuki ysksuzuki commented Aug 30, 2022 •
edited
Loading

Reverts #2063. The XDP acceleration will be applied after the k8s upgrade is released to be on the safe side. Releasing both can make our trouble shooting harder.

@ysksuzuki ysksuzuki requested a review from terassyi August 30, 2022 02:35
terassyi
terassyi previously approved these changes Aug 30, 2022
View reviewed changes
@terassyi
Copy link
Contributor

I confirmed changes.
But a main CI was failed by the error shown bellow.

test -z "$(gofmt -s -l . | grep -v '^build/' | tee /dev/stderr)"
staticcheck -tags='' ./...
nilerr -tags='' ./...
make: nilerr: Command not found
make: *** [Makefile:107: test] Error 127

@ysksuzuki ysksuzuki force-pushed the revert-2063-cilium-pre-native-xdp-enabled branch from 8479721 to d3fdf60 Compare August 30, 2022 07:26
@ysksuzuki ysksuzuki requested a review from terassyi August 30, 2022 07:36
@ysksuzuki
Copy link
Contributor Author

@terassyi I removed nilerr #2070, and rebased this branch.

@terassyi
Copy link
Contributor

LGTM!

@ysksuzuki ysksuzuki merged commit baa4439 into main Aug 30, 2022
@ysksuzuki ysksuzuki deleted the revert-2063-cilium-pre-native-xdp-enabled branch August 30, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terassyi terassyi terassyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ysksuzuki @terassyi