use go:embed for shell scripts used in export and upload Jobs #61
+87
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoru-takeuchi
requested changes
Nov 7, 2024
Comment on lines
56
to
58
| embedJobExportSh string | ||
| //go:embed script/job-upload.sh | ||
| embedJobUploadSh string |
There was a problem hiding this comment.
Suggested change
| embedJobExportSh string | |
| //go:embed script/job-upload.sh | |
| embedJobUploadSh string | |
| embedJobExportScript string | |
| //go:embed script/job-upload.sh | |
| embedJobUploadScript string |
Just minor nits. Since these strings are not shells(Sh) but scripts, ..Script is better.
Signed-off-by: Ryotaro Banno <[email protected]>
ushitora-anqou
force-pushed
the
embed-job-shell-script
branch
from
f7dc2e9
to
45d52ac
Compare
|
@satoru-takeuchi I fixed your points. The changes are: https://github.com/cybozu-go/mantle/compare/f7dc2e959a6986ae2fd50b2d1553b39a073ff090..45d52ac7745948ad66524b427fe576dba15c2d3a. Could you review this PR again? |
satoru-takeuchi
approved these changes
Nov 8, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.