Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add periodic nodeIPAM GC #309

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Add periodic nodeIPAM GC #309

merged 1 commit into from
Feb 7, 2025

Conversation

terassyi
Copy link
Contributor

@terassyi terassyi commented Jan 15, 2025

This PR fixes #271.

Up until now, nodeIPAM GC was triggered only in a start-up procedure, but now it is triggered periodically.

We introduce the new coild flag named addressblock-gc-interval to set the nodeIPAM GC interval and default is 5 minutes.

Signed-off-by: terashima [email protected]

@terassyi terassyi self-assigned this Jan 15, 2025
@terassyi terassyi marked this pull request as ready for review January 15, 2025 04:50
@terassyi terassyi requested a review from chez-shanpu January 15, 2025 04:50
@terassyi terassyi force-pushed the add-addressblock-gc branch from 4dbd168 to 44775c2 Compare February 7, 2025 05:29
Signed-off-by: terashima <[email protected]>
@terassyi terassyi force-pushed the add-addressblock-gc branch from 44775c2 to 365371c Compare February 7, 2025 05:41
@terassyi
Copy link
Contributor Author

terassyi commented Feb 7, 2025

To reproduce #271 in main branch, we have to replace from coil-controller to coil-ipam-controller in procedures.

Copy link
Contributor

@chez-shanpu chez-shanpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terassyi terassyi merged commit c553221 into main Feb 7, 2025
14 checks passed
@terassyi terassyi deleted the add-addressblock-gc branch February 7, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two AddressBlocks are created when coil-controller is temporarily down
2 participants