Fix not to change status of repair-queue's finished entry #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is for the following situation: * there is a finished entry in the repair queue, especially failed one * a new entry with the same target address is queued * the target machine becomes healthy The results of health check are indexed by the target machine's address, not by the entry ID. Though health check is not executed for a finished entry, check for another entry with the same target address can change the status of the failed entry into "succeeded." This commit prevents it. Signed-off-by: morimoto-cybozu <[email protected]>
morimoto-cybozu
added a commit
that referenced
this pull request
May 21, 2024
Signed-off-by: morimoto-cybozu <[email protected]>
morimoto-cybozu
added a commit
that referenced
this pull request
May 22, 2024
Signed-off-by: morimoto-cybozu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is for the following situation:
The results of health check are indexed by the target machine's address,
not by the entry ID.
Though health check is not executed for a finished entry, check for
another entry with the same target address can change the status of
the failed entry into "succeeded."
This commit prevents it.
Signed-off-by: morimoto-cybozu [email protected]