Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rw option to extra volumes #712

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Add rw option to extra volumes #712

merged 1 commit into from
Mar 25, 2024

Conversation

masa213f
Copy link
Contributor

@masa213f masa213f commented Mar 21, 2024

From Docker 25.0.0 or 24.0.5, the parsing volume option has been strict.
docker/cli#4415

With the current implementation, the following error occurs when extra_binds is used.
So, this PR fixes it so that parsing errors do not happen.

root@cke--82-174134-0:~/go/src/github.com/cybozu-go/cke/sonobuoy# ./bin/ckecli --config=./cke.config history | head -n 30
{
    "id": "54",
    "status": "cancelled",
    "operation": "kubelet-bootstrap",
    "command": {
        "name": "run-container",
        "target": "kubelet"
    },
    "targets": [
        "10.174.0.111",
        "10.174.0.112",
        "10.174.0.113"
    ],
    "info": "",
    "error": "Process exited with status 125, cmdline: docker run --log-driver=journald -d --name=kubelet --read-only --network=host --uts=host --pid=host --privileged --tmpfs=/tmp --volume=/etc/machine-id:/etc/machine-id:ro --volume=/etc/os-release:/etc/os-release:ro --volume=/etc/kubernetes:/etc/kubernetes:ro --volume=/var/lib/kubelet:/var/lib/kubelet:rshared --volume=/var/lib/docker:/var/lib/docker: --volume=/opt/volume/bin:/opt/volume/bin:shared --volume=/var/log/pods:/var/log/pods: --volume=/var/log/containers:/var/log/containers: --volume=/run:/run: --volume=/sys:/sys:ro --volume=/dev:/dev: --volume=/opt/cni/bin:/opt/cni/bin:ro --volume=/etc/cni/net.d:/etc/cni/net.d:ro --volume=/var/lib/cni:/var/lib/cni: --label-file=/tmp/8239f4931490879aa5201a804c0b7141 ghcr.io/cybozu/kubernetes:1.27.10.1 kubelet --config=/etc/kubernetes/kubelet/config.yml --kubeconfig=/etc/kubernetes/kubelet/kubeconfig --hostname-override=10.174.0.113 --container-runtime-endpoint=/run/containerd/containerd.sock, stdout: , stderr: docker: invalid spec: /var/log/pods:/var/log/pods:: empty section between colons.\nSee 'docker run --help'.\n",
    "start-at": "2024-03-21T09:30:36.541202703Z",
    "end-at": "2024-03-21T09:30:37.467904031Z"
}

Signed-off-by: Masayuki Ishii <[email protected]>
@masa213f masa213f self-assigned this Mar 21, 2024
@masa213f masa213f marked this pull request as ready for review March 25, 2024 03:08
Copy link
Contributor

@zeroalphat zeroalphat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masa213f masa213f merged commit 53030df into main Mar 25, 2024
8 checks passed
@masa213f masa213f deleted the add-rw-option branch March 25, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants