Enable DNSSEC validation #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yokaze
force-pushed
the
dnssec
branch
5 times, most recently
from
65f765e
to
b18335f
Compare
Signed-off-by: Daichi Sakaue <[email protected]>
masa213f
reviewed
Nov 27, 2023
| @@ -245,6 +259,12 @@ func testKubernetes() { | |||
| return err | |||
| }).Should(Succeed()) | |||
|
|
|||
| By("querying www.dnssec-failed.org using node DNS from ubuntu pod") | |||
There was a problem hiding this comment.
This test is OK.
Could you update the By() just before? Currently, we uses "www.cybozu.com".
By("querying www.google.com using node DNS from ubuntu pod")
Signed-off-by: Daichi Sakaue <[email protected]>
yokaze
added a commit
that referenced
this pull request
Nov 29, 2023
* Enable DNSSEC validation Signed-off-by: Daichi Sakaue <[email protected]>
yokaze
added a commit
that referenced
this pull request
Nov 29, 2023
Backport #675 to enable DNSSEC validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables DNSSEC validation for non-cluster DNS queries.
Signed-off-by: Daichi Sakaue [email protected]