[WIP] libvirt: consume package from flake #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since PR #7525 (Dec 2025)[0], Cloud Hypervisor uses a virtual Cargo manifest and the main package was moved to the `./cloud-hypervisor` subdirectory. This change is effective since v50. As our v49-based CHV version backported these changes already, we need to adapt the Nix build of CHV. [0] cloud-hypervisor/cloud-hypervisor#7525 Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
We do not need the sophisticated logic as this will only run on x86_64.
phip1611
added
the
quality-of-life
phip1611
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should build the libvirt package in the libvirt flake and only consume the package here.
Update Jan 28st! We now have merged the pre-requisite in libvirt [0]!
Time to improve this here as well.
[0] https://gitlab.cyberus-technology.de/cyberus/cloud/libvirt/-/merge_requests/53