Add test that reboots a guest during live migration#88
Draft
tpressure wants to merge 1 commit intocyberus-technology:mainfrom
Draft
Add test that reboots a guest during live migration#88tpressure wants to merge 1 commit intocyberus-technology:mainfrom
tpressure wants to merge 1 commit intocyberus-technology:mainfrom
Conversation
b2bd476 to
9a4dfcf
Compare
phip1611
reviewed
Dec 9, 2025
7c75cca to
81749f5
Compare
On-behalf-of: SAP [email protected] Signed-off-by: Thomas Prescher <[email protected]>
81749f5 to
7fe64cd
Compare
phip1611
requested changes
Jan 21, 2026
Member
phip1611
left a comment
There was a problem hiding this comment.
Please rebase and adapt the code to our latest standards
| controllerVM.succeed("virsh define /etc/domain-chv.xml") | ||
| controllerVM.succeed("virsh start testvm") | ||
|
|
||
| assert wait_for_ssh(controllerVM) |
Member
There was a problem hiding this comment.
obsolete, we now throw exceptions (#121)
Suggested change
| assert wait_for_ssh(controllerVM) | |
| wait_for_ssh(controllerVM) |
|
|
||
| assert wait_for_ssh(controllerVM) | ||
|
|
||
| status, _ = ssh(controllerVM, "screen -dmS stress stress -m 4 --vm-bytes 400M") |
Member
There was a problem hiding this comment.
obsolete, we now throw exceptions (#121)
Suggested change
| status, _ = ssh(controllerVM, "screen -dmS stress stress -m 4 --vm-bytes 400M") | |
| ssh(controllerVM, "screen -dmS stress stress -m 4 --vm-bytes 400M") |
| status, _ = ssh(controllerVM, "screen -dmS stress stress -m 4 --vm-bytes 400M") | ||
| assert status == 0 | ||
|
|
||
| status, _ = ssh(controllerVM, "screen -dmS nohup sh -c 'sleep 10 && reboot'") |
Member
There was a problem hiding this comment.
Suggested change
| status, _ = ssh(controllerVM, "screen -dmS nohup sh -c 'sleep 10 && reboot'") | |
| ssh(controllerVM, "screen -dmS nohup sh -c 'sleep 10 && reboot'") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is is a reproducer for https://github.com/cobaltcore-dev/cobaltcore/issues/374