-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LayoutTree: use different hideCaret name in table #2775
Changes from 4 commits
38c3cef
85cc695
76f038a
650b1f0
7651060
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,4 +23,8 @@ const rootedParentOf = <T extends Context | Path>(state: State, thoughts: T): T | |
: (state.rootContext as T) | ||
} | ||
|
||
/** Calls rootedParentOf twice to get the rooted grandparent of a thought. */ | ||
export const rootedGrandparentOf = <T extends Context | Path>(state: State, thoughts: T): T => | ||
rootedParentOf(state, rootedParentOf(state, thoughts)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As a convention on this project, we generally only allow a single, default export that matches the file name. This makes it easier to know where functions live in the project, and is facilitated by the quick file picker that most editors provide. Reducers/Action Creators are an exception, and a few others, but we try to avoid this when possible. Could move this into its own file in the |
||
|
||
export default rootedParentOf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might also be worth mentioning in this comment the reason that this is needed. i.e. Why is col2 a special case for the
hideCaret
depth?