Note: remove asyncFocus, restore focus on create #2770
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2691
Calling
asyncFocus()
was blurring the editable, settingediting
tofalse
and triggering the whole editable'sonFocus
routine which callssetCursorOnThought
with no offset. WithoutasyncFocus()
, the caret pops back up to the end of the thought when a note is deleted.Notes were also failing to focus in certain situations such as the following:
Explicitly calling
focus()
on the node causes it to focus regardless of how many previous notes have been edited or deleted.