-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate test store with global app store #2756
Consolidate test store with global app store #2756
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good to me. It accomplishes the goal of consolidating the test store with the global app store.
At this time there appears to be little difference between a single beforeEach(initStore)
and a paired beforeEach(skipTutorial)
and afterEach(clear)
, so I'm fine with the single initStore
. We can keep them combined until there is a need otherwise.
Hi @mstrofbass. Just checking in on this. Could you take a look at the few small changes requested above? Then we should be able to get this merged. Thanks! |
f2367ca
to
2bf4d6f
Compare
Okay, should be good to go now. |
My theory is that the reason the enhancers wouldn't work with the test store is because of some weird import issues that resulted in the real createStore being called in src/stores/app.ts. We can bypass fixing #2336 and #2337 by just going straight to the global store.
This change does the following:
store
references that originate withcreateTestStore
with references directly to the storeinitStore
in thebeforeEach
when appropriate.Closes #2336
Closes #2337
Closes #2338