fix: use table names from config file #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsraelOrtuno
changed the title
|
@IsraelOrtuno thank you for the contribution! I will try to review and merge it ASAP |
|
@IsraelOrtuno Just released v10.0.1 |
|
Amazing! Congrats on the package looks so great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two migrations (
love_reactant_reaction_countersandlove_reactant_reaction_totals) that use hardcoded table names instead of dynamically fetching table names with model'sgetTable(). This causes an error when running the migrations as those tables do not exist. This PR solves this issue by just replacing the hardcoded table names by the model'sgetTable().