Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URDF loading to include default robot configuration in Ros2Control #1011

Closed
wants to merge 2 commits into from

Conversation

skpawar1305
Copy link
Contributor

Description
For the latest ros2_control update we face
[webots_controller_SpotArm-6] terminate called after throwing an instance of 'std::runtime_error'
[webots_controller_SpotArm-6] what(): Hardware name WebotsControl is duplicated. Please provide a unique 'name' in the URDF. for humble

Affected Packages
List of affected packages:

  • webots_ros2_control

Additional context
load_urdf is called only to set is_urdf_loaded__ = true

…trol

fixes
[webots_controller_SpotArm-6] terminate called after throwing an instance of 'std::runtime_error'
[webots_controller_SpotArm-6]   what():  Hardware name WebotsControl is duplicated. Please provide a unique 'name' in the URDF. for humble
@skpawar1305 skpawar1305 requested review from ralphieraccoon and omichel and removed request for ralphieraccoon December 10, 2024 03:47
@omichel omichel requested review from lukicdarkoo and removed request for omichel December 12, 2024 09:41
@lukicdarkoo
Copy link
Member

@skpawar1305 Can you confirm the error occurred on Humble main (not testing) and Webots R2023b? Or it is some other version?

@skpawar1305
Copy link
Contributor Author

skpawar1305 commented Dec 12, 2024

@skpawar1305 Can you confirm the error occurred on Humble main (not testing) and Webots R2023b? Or it is some other version?

yes
our workflow is also failing, webots 2023b and stable ros2 repos
https://github.com/MASKOR/webots_ros2_spot/blob/main/.github/workflows/test_ros2_humble.yml

@lukicdarkoo
Copy link
Member

@skpawar1305 I managed to reproduce the error in our test examples. With the latest ros2_control for Humble (compiled from source) there is no error. I believe the issue is related:
ros-controls/ros2_control#1960

Given load_urdf is called with:

  • validate_interfaces = false
  • load_and_initialize_components = false
    the error should not appear.

@skpawar1305
Copy link
Contributor Author

okay, I'll delete this branch later then. thank you

@lukicdarkoo
Copy link
Member

@skpawar1305 Here is a hotfix until the Humble sync:

# HOTFIX: https://github.com/ros-controls/ros2_control/pull/1960
wget -O /tmp/hotfix.deb http://snapshots.ros.org/humble/2024-08-28/ubuntu/pool/main/r/ros-humble-hardware-interface/ros-humble-hardware-interface_2.43.0-1jammy.20240823.145349_amd64.deb && \
    sudo apt install -y --allow-downgrades /tmp/hotfix.deb && \
    rm -f /tmp/hotfix.deb

It will install a slightly older version of resource_manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants