upgrading nokogiri from 1.8.0 to 1.8.1 #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also updates dependency mini_portile2 from 2.2.0 to 2.3.0
ghost
assigned 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #410
There are other project dependencies that require older versions of nokogiri, and not all have been updated to use 1.8.1. I am adding a backlog item here that tracks the outstanding work that will need to be done to continue addressing this vulnerability.
I ran the rspec and cucumber tests after making this update, and they all passed.
I didn't find anywhere in the documentation that included reference to the version of nokogiri, so I don't think anything needed to be updated around that.