This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Added build instructions for newbies to Csharp. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -108,7 +108,7 @@ private void BrowseTo(string url) | |||
| webBrowser.Visible = true; | |||
| try | |||
| { | |||
| Debug.WriteLine($"Navigating: {url}"); | |||
There was a problem hiding this comment.
That $ is for string interpolation. if you got a build error with it in that means you've not got the most recent .Net version selected as string interpolation was added in C# 6
https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/tokens/interpolated
(with string interpolation $"Navigating: {url}" is equivalent to "Navigating: " +url.toString() removing the $ changes the meaning to be the hardcoded and booring string: "Navigating: {url}"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is the first time I contribute to open source projects, so please bear with me.
As there are quite few new features, I wanted, added since the last release, I wanted to build it myself.
After a bit of googling, I found out how to do it. To save time for the next one like me I added the instructions to the readme.
My compiler also failed on a "$" in the code. I deleted it and hope it is not necessary.
Cheers,
Topsrek