Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: merge apps #608

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

refactor: merge apps #608

wants to merge 16 commits into from
+2,080 −1,043

Conversation

DanielSchiavini
Copy link
Contributor

@DanielSchiavini DanielSchiavini commented Jan 17, 2025 •
edited
Loading

  • move main/src to main/src/dex
  • move ${app}/src to main/src/${app}
  • merge locales into main/src/locales
  • merge app configuration and pages (one route per old app)
  • create empty apps for redirection in existing envs
  • reviewers might want to run the following snippet to mark 924 moved files that didn't change as read
Array.from(document.getElementsByClassName('js-reviewed-checkbox')).filter(i => i.parentNode.parentNode.parentNode.parentNode.parentNode.parentNode.querySelector('.diffstat').innerText.trim() == '0').forEach(i => !i.checked && i.click())

@DanielSchiavini
refactor: merge all apps into main
036aeaa 
mkdir -p apps/main/dex
mv apps/main/src/* apps/main/dex/
mv apps/main/dex apps/main/src/
mv apps/dao/src apps/main/src/dao
mv apps/lend/src apps/main/src/lend
mv apps/loan/src apps/main/src/loan
@DanielSchiavini
refactor: merge app routes, locales and config
a65c646
@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
curve-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 9:34pm
curve-dapp-crvusd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 9:34pm
curve-dapp-dao ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 9:34pm
curve-dapp-lend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 9:34pm
curve-dapp-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 9:34pm

@DanielSchiavini DanielSchiavini mentioned this pull request Jan 17, 2025
Closed
5 tasks
@DanielSchiavini DanielSchiavini marked this pull request as ready for review January 17, 2025 18:16
DanielSchiavini
DanielSchiavini commented Jan 18, 2025
View reviewed changes
lingui.config.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DanielSchiavini