Implement Typescript "funk" using queries
#1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
force-pushed
the
pokey/implement-more-typescript-scope-types-using-queries
branch
4 times, most recently
from
be6bdda
to
adf03e9
Compare
pokey
changed the title
pokey
changed the title
"funk" using queries
pokey
force-pushed
the
pokey/implement-more-typescript-scope-types-using-queries
branch
6 times, most recently
from
23bdbf3
to
381617c
Compare
pokey
commented
Jun 9, 2023
There was a problem hiding this comment.
I have mixed feelings about this one. I think I'd prefer if "name" from within the const modifier targeted the first name (aaa) rather than both at the same time. But this was easier to implement, I don't think this corner case is super common, and it is kind of ambiguous anyway
| ) | ||
| ) | ||
| ) @_.domain | ||
| (#allow-multiple! @name) |
There was a problem hiding this comment.
As mentioned above, mixed feelings about this one, but was super easy 🤷♂️
pokey
force-pushed
the
pokey/implement-more-typescript-scope-types-using-queries
branch
from
381617c
to
004d0b8
Compare
pokey
force-pushed
the
pokey/implement-more-typescript-scope-types-using-queries
branch
from
004d0b8
to
1f68e5e
Compare
pokey
force-pushed
the
pokey/implement-more-typescript-scope-types-using-queries
branch
2 times, most recently
from
fed023b
to
0a49728
Compare
|
ok @AndreasArvidsson i think this one is good to go; would be worth a quick scan esp through the unit tests looking forward to #1524 so that the tests won't be so verbose 😅 |
packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/typescript/clearFunk10.yml
Show resolved
Hide resolved
AndreasArvidsson
approved these changes
Jun 16, 2023
pokey
deleted the
pokey/implement-more-typescript-scope-types-using-queries
branch
pokey
added
lang-typescript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
export#711exportkeyword ofinterface#1238Checklist
"name"behaves as well as"funk name"now does"funk name"=>"name funk", and then remove all the"funk name"stuff (MigratefunctionNameto just pipenamedFunctionintoname#1518). Might want to bail on that