Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Typescript "funk" using queries #1516

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

pokey
Copy link
Member

@pokey pokey commented Jun 7, 2023

Checklist

@pokey pokey force-pushed the pokey/implement-more-typescript-scope-types-using-queries branch 4 times, most recently from be6bdda to adf03e9 Compare June 9, 2023 14:55
@pokey pokey changed the title Implement more Typescript scope types using queries Implement Typescript functions using queries Jun 9, 2023
@pokey pokey changed the title Implement Typescript functions using queries Implement Typescript "funk" using queries Jun 9, 2023
@pokey pokey force-pushed the pokey/implement-more-typescript-scope-types-using-queries branch 6 times, most recently from 23bdbf3 to 381617c Compare June 9, 2023 16:49
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mixed feelings about this one. I think I'd prefer if "name" from within the const modifier targeted the first name (aaa) rather than both at the same time. But this was easier to implement, I don't think this corner case is super common, and it is kind of ambiguous anyway

)
)
) @_.domain
(#allow-multiple! @name)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above, mixed feelings about this one, but was super easy 🤷‍♂️

@pokey pokey marked this pull request as ready for review June 9, 2023 16:51
@pokey pokey force-pushed the pokey/implement-more-typescript-scope-types-using-queries branch from 381617c to 004d0b8 Compare June 9, 2023 16:54
@pokey pokey added the to discuss Plan to discuss at meet-up label Jun 13, 2023
@pokey pokey force-pushed the pokey/implement-more-typescript-scope-types-using-queries branch from 004d0b8 to 1f68e5e Compare June 13, 2023 13:21
@pokey pokey force-pushed the pokey/implement-more-typescript-scope-types-using-queries branch 2 times, most recently from fed023b to 0a49728 Compare June 15, 2023 14:53
@pokey pokey enabled auto-merge June 15, 2023 15:20
@pokey pokey removed the to discuss Plan to discuss at meet-up label Jun 15, 2023
@pokey
Copy link
Member Author

pokey commented Jun 15, 2023

ok @AndreasArvidsson i think this one is good to go; would be worth a quick scan esp through the unit tests

looking forward to #1524 so that the tests won't be so verbose 😅

@pokey pokey added this pull request to the merge queue Jun 16, 2023
Merged via the queue into main with commit 0fe1b84 Jun 16, 2023
@pokey pokey deleted the pokey/implement-more-typescript-scope-types-using-queries branch June 16, 2023 07:07
@pokey pokey added lang-typescript TypeScript/JavaScript grammar support scope-migration Migrating scopes to next-gen scope implementation labels Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-typescript TypeScript/JavaScript grammar support scope-migration Migrating scopes to next-gen scope implementation
Projects
None yet
2 participants