Merge pull request #49 from curie-data-factory/jupyterlab

Jupyterlab
curie-data-factory · Apr 7, 2022 · 6b47f1a · 6b47f1a
2 parents 0cf153d + 86a9855
commit 6b47f1a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/charts/jupyterlab/Chart.yaml b/charts/jupyterlab/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v2
 name: jupyterlab
 appVersion: "jupyter/datascience-notebook:python-3.9.6"
-version: "0.1.2"
+version: "0.1.3"
 description: jupyterlab data science notebook
 home: https://github.com/curie-data-factory/helm-charts/tree/master/charts/jupyterlab
 icon: https://jupyter.org/assets/homepage/main-logo.svg

diff --git a/charts/jupyterlab/templates/statefulset.yaml b/charts/jupyterlab/templates/statefulset.yaml
@@ -60,15 +60,20 @@ spec:
         - containerPort: {{ .Values.service.targetPort }}
           name: {{ .Values.service.targetPort }}{{ .Values.service.protocol | lower }}
           protocol: {{ .Values.service.protocol }}
+        {{- if .Values.root }}
+        securityContext:
+          allowPrivilegeEscalation: true
+          runAsUser: 0
+        {{- end }}
         resources:
           requests:
             cpu: "1"
             memory: 1000Mi
-        {{- if .Values.resources.enabled }}          
+        {{- if .Values.resources.enabled }}
           limits:
             cpu: "{{ .Values.resources.cpu }}"
             memory: {{ .Values.resources.memory }}
-        {{- end }}            
+        {{- end }}
         volumeMounts:
         {{- if .Values.gpu.enabled }}
         - mountPath: "/tf"

diff --git a/charts/jupyterlab/values.yaml b/charts/jupyterlab/values.yaml
@@ -2,6 +2,7 @@
 replicaCount: 1
 
 user: master
+root: false
 
 gpu:
   enabled: false