Minor tweaks #3
Open
Minor tweaks #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- postgres_db_user is normally the same as <app_name> - with the default Postgres hba.conf, connections to localhost use peer authentication, using 127.0.0.1 prevents this problem
matt17r
commented
Dec 12, 2020
| @@ -1,7 +1,7 @@ | |||
| --- | |||
| environment_vars: | |||
| TEST_NAME: ayyylmao | |||
| DATABASE_HOST: localhost | |||
| DATABASE_HOST: 127.0.0.1 | |||
| DATABASE_NAME: "{{ postgres_db_name }}" | |||
| DATABASE_USERNAME: "{{ postgres_db_user }}" | |||
| DATABASE_PASSWORD: "{{ postgres_db_password }}" | |||
There was a problem hiding this comment.
Technically a new Rails app expects the DATABASE_PASSWORD ENV VAR to be named APP_NAME_DATABASE_PASSWORD but since we have to load all the other ENV VARs into database.yml anyway there's probably no need to change it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few more suggestions while I'm in the code 🙂