Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create files in /etc/iproute2 out of thin air #165

Closed

Conversation

Infinoid
Copy link
Contributor

Fixes: #164

stv0g and others added 21 commits March 25, 2024 19:36
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
@Infinoid Infinoid requested a review from stv0g as a code owner May 21, 2024 12:19
@Infinoid
Copy link
Contributor Author

I was not able to run your unit tests; I get a timeout after 10 minutes. Please let me know if it breaks anything else.

I tested this using one of my own tests; it worked for me.

Before patch:

  • no /etc/iproute2 directory
  • run test (success)
  • /etc/iproute2 exists
  • /etc/iproute2/group file exists and is empty

After patch:

  • no /etc/iproute2 directory
  • run test (success)
  • no /etc/iproute2 directory

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 44.06780% with 33 lines in your changes missing coverage. Please review.

Project coverage is 50.64%. Comparing base (2575061) to head (7cd1773).
Report is 71 commits behind head on main.

Files with missing lines Patch % Lines
pkg/network_files.go 52.00% 14 Missing and 10 partials ⚠️
pkg/exec.go 0.00% 5 Missing ⚠️
internal/utils/utils.go 0.00% 1 Missing and 1 partial ⚠️
pkg/options/cmd/exec.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   50.60%   50.64%   +0.03%     
==========================================
  Files          67       67              
  Lines        3140     3197      +57     
==========================================
+ Hits         1589     1619      +30     
- Misses       1336     1352      +16     
- Partials      215      226      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stv0g
Copy link
Collaborator

stv0g commented Oct 27, 2024

Will be resolved with #215

@stv0g stv0g closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use OverflayFS instead of bind mounts
2 participants