Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

III-3558 Replace json_decode with Json::decode #1741

Merged
merged 4 commits into from
Aug 9, 2024
Merged

III-3558 Replace json_decode with Json::decode #1741

merged 4 commits into from
Aug 9, 2024

Conversation

LucWollants
Copy link
Contributor

Changed

  • Replaced json_decode with Json::decode

Removed

-Removed NotWellFormedException and used JsonException

Note

  • This is a prerequisite to increase the PHPStan level to 7

Ticket: https://jira.uitdatabank.be/browse/III-3558

@LucWollants @JonasVHG
Fix typo
43ffc95 
Co-authored-by: JonasVHG <[email protected]>
Base automatically changed from III-3558-replace-json-encode to master August 9, 2024 07:20
@LucWollants LucWollants merged commit f202618 into master Aug 9, 2024
8 checks passed
@LucWollants LucWollants deleted the III-3558-replace-json-decode branch August 9, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasVHG JonasVHG JonasVHG approved these changes

@simon-debruijn simon-debruijn Awaiting requested review from simon-debruijn simon-debruijn is a code owner

@grubolsch grubolsch Awaiting requested review from grubolsch grubolsch is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucWollants @JonasVHG