Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

III-3558 Replace json_encode with Json::encode #1740

Merged
merged 1 commit into from
Aug 9, 2024
Merged

III-3558 Replace json_encode with Json::encode #1740

merged 1 commit into from
Aug 9, 2024

Conversation

LucWollants
Copy link
Contributor

Changed

  • Replaced json_encode with Json::encode for two main reasons:
    • By using the wrapper method throwing an error is enforced
    • The returned type is always a string and not string|boolean as with the built-in method

Note

  • This is a prerequisite to increase the PHPStan level to 7

Ticket: https://jira.uitdatabank.be/browse/III-3558

@LucWollants LucWollants merged commit 1cdafbf into master Aug 9, 2024
8 checks passed
@LucWollants LucWollants deleted the III-3558-replace-json-encode branch August 9, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasVHG JonasVHG JonasVHG approved these changes

@simon-debruijn simon-debruijn simon-debruijn approved these changes

@grubolsch grubolsch Awaiting requested review from grubolsch grubolsch is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucWollants @JonasVHG @simon-debruijn